Skip to content

Conversation

@fdiblen
Copy link
Member

@fdiblen fdiblen commented Aug 28, 2024

Checklist before requesting a review

  • I have read the contribution guidelines
  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • All user facing changes have been added to CHANGELOG.md

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

List of related issues or pull requests**

Fixes:

Describe the changes made in this pull request

Added value field to licenses and updated if condition in the filenames.

Instructions to review the pull request

Install the requirements

cd $(mktemp -d --tmpdir py-tmpl-XXXXXX)
pip install pipx
pipx install copier

Create a new package using the template

copier copy --vcs-ref 570_license_not_created https://github.com/nlesc/python-template test_package

Create a local git repo to push to GitHub to trigger CI actions

git init
git add --all
git commit -m "First commit"
git remote add origin git@github.com:<YOU>/python-template-test.git
git push -u origin main -f
# Create a local environment to test your generated package locally
python -m venv env
source env/bin/activate
python -m pip install --upgrade pip setuptools
python -m pip install '.[dev,publishing]'

@fdiblen fdiblen changed the title 570-rename not open source license as other 570-fix license file generation Aug 28, 2024
@fdiblen fdiblen marked this pull request as ready for review August 28, 2024 10:13
@lyashevska lyashevska self-requested a review August 28, 2024 10:53
Copy link
Collaborator

@lyashevska lyashevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @fdiblen all works as expected.

@fdiblen fdiblen merged commit d21c1d5 into main Aug 28, 2024
@fdiblen fdiblen deleted the 570_license_not_created branch August 28, 2024 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants